Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include_role: expose vars from parent roles to role's handlers #81524

Merged
merged 2 commits into from Aug 17, 2023
Merged

include_role: expose vars from parent roles to role's handlers #81524

merged 2 commits into from Aug 17, 2023

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Aug 16, 2023

SUMMARY

Fixes #80459

ISSUE TYPE
  • Bugfix Pull Request
ADDITIONAL INFORMATION

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. has_issue labels Aug 16, 2023
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 16, 2023
@webknjaz
Copy link
Member

The CI failure on F38 is known and will hopefully be fixed by tomorrow. I restarted it now just in case. May need to re-attempt tomorrow.

@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Aug 16, 2023
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Aug 17, 2023
@s-hertel s-hertel merged commit 98f1627 into ansible:devel Aug 17, 2023
78 checks passed
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Aug 17, 2023
@mkrizek mkrizek deleted the issue-80459 branch August 21, 2023 06:27
mkrizek added a commit to mkrizek/ansible that referenced this pull request Aug 21, 2023
@mkrizek
include_role: expose vars from parent roles to role's handlers (ansib…
a433483 
…le#81524)

* include_role: expose vars from parent roles to role's handlers

Fixes ansible#80459

(cherry picked from commit 98f1627)
@mkrizek mkrizek mentioned this pull request Aug 21, 2023
Merged
mkrizek added a commit to mkrizek/ansible that referenced this pull request Aug 31, 2023
@mkrizek
include_role: expose vars from parent roles to role's handlers (ansib…
6b9b78d 
…le#81524)

Fixes ansible#80459

(cherry picked from commit 98f1627)
sivel pushed a commit that referenced this pull request Aug 31, 2023
@mkrizek
include_role: expose vars from parent roles to role's handlers (#81524)…
caf8cdb 
… (#81548)

Fixes #80459

(cherry picked from commit 98f1627)
@ansible ansible locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. has_issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable in handlers of nested included role is undefined if left set to default
5 participants
@mkrizek @webknjaz @bcoca @ansibot @s-hertel